linux-kernel - Re: [PATCH v2] UBI: add lnum to struct ubi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1337084131.2528.189.camel@sauron.fi.intel.com>
Date:	Tue, 15 May 2012 15:15:31 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Joel Reardon <joel@...mbassador.com>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] UBI: add lnum to struct ubi_work

On Tue, 2012-05-15 at 13:47 +0200, Joel Reardon wrote:
> For vol_id, its straightforward everywhere except: ubi_wl_init_scan()
> 
> where scheduling erase on the:
> 
> struct ubi_scan_leb *seb
> 
> appears to lack access to the volume id.  Should we add vol_id to
> ubi_scan_leb, and in ubi_scan() run:
> 
>         ubi_rb_for_each_entry(rb1, sv, &si->volumes, rb) {
>                 ubi_rb_for_each_entry(rb2, seb, &sv->root, u.rb)
> 			seb->vol_id = sv->vol_id;
> 
> Or is there a simpler way?

I guess yes. Add this field as a separate patch please.

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)