linux-kernel - RE: [PATCH] staging: comedi: refactor ni_pcimio driver and use module_comedi_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ADE657CA350FB648AAC2C43247A983F0020698AE0932@AUSP01VMBX24.collaborationhost.net>
Date:	Tue, 15 May 2012 10:41:23 -0500
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Ian Abbott <ian.abbott@....co.uk>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH] staging: comedi: refactor ni_pcimio driver and use
 module_comedi_pci_driver

On Tuesday, May 15, 2012 4:29 AM, Ian Abbott wrote:
> On 2012-05-12 00:51, H Hartley Sweeten wrote:
>> +static struct comedi_driver ni_pcimio_driver = {
>> +	.driver_name	= "ni_pcimio",
>
> The original used the DRV_NAME macro expanding to "ni_pcimio" here...
>
>> +static struct pci_driver ni_pcimio_pci_driver = {
>> +	.name		= "ni_pcimio",
>
> ... which could also be used here.
>
>  (I realize this is a bit late as the patch is already committed!)

I noticed that. A couple of the comedi drivers do this but it's not consistent.

Personally I don't care for the use of the DRV_NAME (or DRIVER_NAME
or whatever someone wants to call it) usage. It doesn't same any code
space and always makes me have to do a second search to see what the
"name" actually is.

Regardsless, if you prefer this in the drivers please let me know. It
would be nice to have them somewhat consistent before the comedi
support leaves staging.

Regards,
Hartley