linux-kernel - Re: [PATCH] x86: Fix boot on Twinhead H12Y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337100727.7050.17.camel@joe2Laptop>
Date:	Tue, 15 May 2012 09:52:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Fix boot on Twinhead H12Y

On Tue, 2012-05-15 at 18:44 +0100, Alan Cox wrote:
> Despite lots of investigation into why this is needed we don't know or have
> an elegant cure. The only answer found on this laptop is to mark a problem
> region as used so that Linux doesn't put anything there.

trivia:

> diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
[]
> @@ -519,3 +519,22 @@ static void sb600_disable_hpet_bar(struct pci_dev *dev)
[]
> +static void __devinit twinhead_reserve_killing_zone(struct pci_dev *dev)
> +{
> +        if (dev->subsystem_vendor == 0x14FF && dev->subsystem_device ==
> +                                        0xA003) {

Doesn't this look ugly to you?
Doesn't 

	if (dev->subsystem_vendor == 0x14FF &&
	    dev->subsystem_device == 0xA003) {

at least read more easily?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/