linux-kernel - Re: [tip:sched/core] sched/numa: Fix the new NUMA topology bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE9FiQV7xz1nntEiUfwXwSLQGNQWoVKVnymMn9EuMd2gLFm_6g@mail.gmail.com>
Date:	Tue, 15 May 2012 10:49:07 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	yinghai@...nel.org, a.p.zijlstra@...llo.nl, greg.pearson@...com,
	tglx@...utronix.de
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched/numa: Fix the new NUMA topology bits

On Mon, May 14, 2012 at 6:43 AM, tip-bot for Peter Zijlstra
<a.p.zijlstra@...llo.nl> wrote:
> Commit-ID:  dd7d8634e619b715a537402672d1383535ff4c54
> Gitweb:     http://git.kernel.org/tip/dd7d8634e619b715a537402672d1383535ff4c54
> Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> AuthorDate: Fri, 11 May 2012 00:56:20 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Mon, 14 May 2012 15:05:25 +0200
>
> sched/numa: Fix the new NUMA topology bits
>
> There's no need to convert a node number to a node number by
> pretending its a cpu number..
>
> Reported-by: Yinghai Lu <yinghai@...nel.org>
> Reported-and-Tested-by: Greg Pearson <greg.pearson@...com>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Link: http://lkml.kernel.org/n/tip-0sqhrht34phowgclj12dgk8h@git.kernel.org
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> ---
>  kernel/sched/core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index b4f2096..0738036 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6395,8 +6395,7 @@ static void sched_init_numa(void)
>                        sched_domains_numa_masks[i][j] = mask;
>
>                        for (k = 0; k < nr_node_ids; k++) {
> -                               if (node_distance(cpu_to_node(j), k) >
> -                                               sched_domains_numa_distance[i])
> +                               if (node_distance(j, k) > sched_domains_numa_distance[i])
>                                        continue;
>
>                                cpumask_or(mask, mask, cpumask_of_node(k));

this one should be folded into offending commit

Commit-ID:  cb83b629bae0327cf9f44f096adc38d150ceb913
Gitweb:     http://git.kernel.org/tip/cb83b629bae0327cf9f44f096adc38d150ceb913
Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
AuthorDate: Tue, 17 Apr 2012 15:49:36 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 9 May 2012 15:00:55 +0200

sched/numa: Rewrite the CONFIG_NUMA sched domain support

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/