lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 May 2012 17:35:09 -0400 From: Seiji Aguchi <seiji.aguchi@....com> To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Luck, Tony (tony.luck@...el.com)" <tony.luck@...el.com>, "dzickus@...hat.com" <dzickus@...hat.com>, "'mingo@...e.hu' (mingo@...e.hu)" <mingo@...e.hu>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl> CC: "dle-develop@...ts.sourceforge.net" <dle-develop@...ts.sourceforge.net>, Satoru Moriya <satoru.moriya@....com> Subject: [PATCH -tip] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop() Hi, As Don mentioned in following thread, it would be nice for pstore/kmsg_dump to serialize panic path because they can log messages reliably. https://lkml.org/lkml/2011/10/13/427 This patch is based on Don's proposal switching smp_send_stop() from REBOOT_VECTOR to NMI which has already merged to -tip tree. https://lkml.org/lkml/2012/5/14/145 [Patch Description] This patch just moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop for serializing logging process via smp_send_stop. Signed-off-by: Seiji Aguchi <seiji.aguchi@....com> Acked-by: Don Zickus <dzickus@...hat.com> --- kernel/panic.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index 80aed44..da585b8 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -108,8 +108,6 @@ void panic(const char *fmt, ...) */ crash_kexec(NULL); - kmsg_dump(KMSG_DUMP_PANIC); - /* * Note smp_send_stop is the usual smp shutdown function, which * unfortunately means it may not be hardened to work in a panic @@ -117,6 +115,8 @@ void panic(const char *fmt, ...) */ smp_send_stop(); + kmsg_dump(KMSG_DUMP_PANIC); + atomic_notifier_call_chain(&panic_notifier_list, 0, buf); bust_spinlocks(0); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists