linux-kernel - Re: [PATCH 2/4] ARM: dt: tegra20.dtsi: Add Memory Controller(MC) nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120516095107.3510cb39d0f9cd2527e0bf1e@nvidia.com>
Date:	Wed, 16 May 2012 09:51:07 +0300
From:	Hiroshi Doyu <hdoyu@...dia.com>
To:	Olof Johansson <olof@...om.net>
CC:	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"Russell King" <linux@....linux.org.uk>,
	Stephen Warren <swarren@...dotorg.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Simon Glass <sjg@...omium.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] ARM: dt: tegra20.dtsi: Add Memory Controller(MC)
 nodes

Hi Olof,

On Wed, 16 May 2012 08:35:02 +0200
Olof Johansson <olof@...om.net> wrote:

> Hi,
> 
> Tiny drive-by nit pick.
> 
> On Thu, May 10, 2012 at 12:42 AM, Hiroshi DOYU <hdoyu@...dia.com> wrote:
> > Add Tegra MC(Memory Controller) nodes for tegra20.dtsi.
> >
> > Signed-off-by: Hiroshi DOYU <hdoyu@...dia.com>
> > ---
> >  arch/arm/boot/dts/tegra20.dtsi |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> > index 24129fb..548b42e 100644
> > --- a/arch/arm/boot/dts/tegra20.dtsi
> > +++ b/arch/arm/boot/dts/tegra20.dtsi
> > @@ -211,5 +211,12 @@
> >                compatible = "nvidia,tegra20-ahb";
> >                reg = <0x6000c004 0x10c>; /* AHB Arbitration + Gizmo Controller */
> >        };
> > +
> > +       mc {
> 
> It's common to use a more plain english name here, so
> "memory-controller" would be a good name.

Agree. Seems to be common as below. Fix patches follows, which can be squashed if possible.

$% grep memory-controller arch/arm/boot/dts/*
arch/arm/boot/dts/prima2-cb.dts:                        memory-controller@...00000 {
arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts:    memory-controller@...a0000 {
arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts:    memory-controller@...d0000 {
arch/arm/boot/dts/vexpress-v2p-ca5s.dts:        memory-controller@...50000 {
arch/arm/boot/dts/vexpress-v2p-ca5s.dts:        memory-controller@...90000 {
arch/arm/boot/dts/vexpress-v2p-ca9.dts: memory-controller@...e0000 {
arch/arm/boot/dts/vexpress-v2p-ca9.dts: memory-controller@...e1000 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/