linux-kernel - RE: [PATCH v2 1/7] backlight: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <003001cd3335$50cc4520$f264cf60$%han@samsung.com>
Date:	Wed, 16 May 2012 16:27:14 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Joe Perches' <joe@...ches.com>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Richard Purdie' <rpurdie@...ys.net>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: RE: [PATCH v2 1/7] backlight: use pr_warn instead of printk

On Wed, 16 May 2012 14:29:00 +0900
Joe Perches <joe@...ches.com> wrote:

> 
> On Wed, 2012-05-16 at 14:08 +0900, Jingoo Han wrote:
> > This patch uses pr_warn instead of printk to allow dynamic debugging.
> 
> A slight mistake in the commit message.
> pr_debug not pr_warn.
> 
> > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> > index bf5b1ec..f7ce212 100644
> > --- a/drivers/video/backlight/backlight.c
> > +++ b/drivers/video/backlight/backlight.c
> > @@ -5,6 +5,8 @@
> >   *
> >   */
> >
> > +#define pr_fmt(fmt) "backlight: " fmt
> 
> I'd prefer:
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Hi, Joe Perches.

Thank you for your comment.
I will fix the commit message and pr_fmt.

Best regards,
Jingoo Han

> 
> > diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
> > index 1c298d5..e61db49 100644
> > --- a/drivers/video/backlight/lcd.c
> > +++ b/drivers/video/backlight/lcd.c
> > @@ -5,6 +5,8 @@
> >   *
> >   */
> >
> > +#define pr_fmt(fmt) "lcd: " fmt
> 
> KBUILD_MODNAME here too


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/