linux-kernel - Re: [WARNING] at kernel/irq/manage.c:421 __enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337169432.6724.30.camel@gandalf.stny.rr.com>
Date:	Wed, 16 May 2012 07:57:12 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [WARNING] at kernel/irq/manage.c:421 __enable_irq

On Wed, 2012-05-16 at 13:27 +0200, Thomas Gleixner wrote:
> On Tue, 15 May 2012, Steven Rostedt wrote:
> > The code in ide_probe_port() does the following:
> 
> Right, you just forgot to show the most interesting gem of that code:
> 
> 	/*
> 	 * We must always disable IRQ, as probe_for_drive will assert IRQ, but
> 	 * we'll install our IRQ driver much later...
> 	 */

Heh, I would have kept that, but I was more interested in cut and
pasting code than comments. I'll make sure to keep comments in emails
too.

> >         if (irqd)
> >                 enable_irq(irqd);
> 
> So this code is wrong and unsafe in various aspects. I wonder why it
> didn't blow up before. Maybe init ordering changed ....
> 

Or it always did. This is on my main box that I reboot once every 100
days or so. I'm not usually present when the machine comes online, nor
do I search dmesg for warnings. Although, yesterday I did. This could
have been complaining from day one.

> I have an idea how to fix that proper. Will send out patches later.

I'll test them, but it's a bit of a pain, as it would require me
shutting down evolution, xchat, firefox, chrome and all my emacs
windows :-)  This is why I don't reboot this box often.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/