linux-kernel - Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120515183536.2cac1e29@nehalam.linuxnetplumber.net>
Date:	Tue, 15 May 2012 18:35:36 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert
 printk(KERN_DEBUG to pr_debug

On Tue, 15 May 2012 17:11:54 -0700
Joe Perches <joe@...ches.com> wrote:

> Use the current debugging style and enable dynamic_debug.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

This changes the action of the system. By default:
  printk(KERN_DEBUG "foo\n");
is enabled all the time and prints to log with debug level.

But your version
  pr_debug("foo\n");
defaults to being dropped until the system is built with dynamic
debug, and that particular debug instance is enabled.

Since these are all useful, but low priority messages, not I
don't think disabling them by default is such a great idea now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/