| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120516170324.337f2932@pixies.home.jungo.com> Date: Wed, 16 May 2012 17:03:24 +0300 From: Shmulik Ladkani <shmulik.ladkani@...il.com> To: Richard Weinberger <richard@....at> Cc: linux-mtd@...ts.infradead.org, dedekind1@...il.com, linux-kernel@...r.kernel.org, Heinz.Egger@...utronix.de, tim.bird@...sony.com, tglx@...utronix.de Subject: Re: [PATCH 1/7] [RFC] UBI: Export next_sqnum() Hi Richard, On Tue, 15 May 2012 19:11:05 +0200 Richard Weinberger <richard@....at> wrote: > The fastmap mechanism needs to read the next sequence nummber > directly. > > Signed-off-by: Richard Weinberger <richard@....at> > --- > drivers/mtd/ubi/eba.c | 18 +++++++++--------- > drivers/mtd/ubi/ubi.h | 1 + > 2 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c > index bd5fdbf..d75677d 100644 > --- a/drivers/mtd/ubi/eba.c > +++ b/drivers/mtd/ubi/eba.c > @@ -57,7 +57,7 @@ > * global sequence counter value. It also increases the global sequence > * counter. > */ > -static unsigned long long next_sqnum(struct ubi_device *ubi) > +unsigned long long ubi_next_sqnum(struct ubi_device *ubi) Minor nit. Comment above the function should have been changed too. (look for the "next_sqnum - get next sequence number" comment) Other than that, Reviewed-by: Shmulik Ladkani <shmulik.ladkani@...il.com> Regards, Shmulik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists