linux-kernel - Re: [PATCH] driver: char: bfin_crc: CRC hardware accelerator driver for BF60x family processors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201205161511.27232.arnd@arndb.de>
Date:	Wed, 16 May 2012 15:11:26 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:	sonic.zhang@...log.com, LKML <linux-kernel@...r.kernel.org>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH] driver: char: bfin_crc: CRC hardware accelerator driver for BF60x family processors.

On Wednesday 16 May 2012, Greg Kroah-Hartman wrote:
> > Do we have a userspace crypto API these days? The last I remember every
> > attempt to add one so far was abandoned before it got merged. There is
> > drivers/s390/crypto/zcrypt*, which has a nonportable API, and 
> > then there is the in-kernel crypto layer in drivers/crypto that has
> > no user interface at all.
> 
> What is CONFIG_CRYPTO_USER for then, with the matching,
> crypto/crypto_user.c file?

Ah, I completely missed that going in and looked in the wrong place
when trying to find it now (/drivers/crypto, not /crypto). I'm glad
that part is resolved.

> > I agree that having another private driver for bfin_crc is not a good
> > idea, but I also don't have a better one.
> > 
> > About the driver itself, the submission seems incomplete (missing at
> > least the bfin_crc.h file) and the driver has a number of shortcomings
> > that we should discuss in case we decide to merge it.
> 
> I suggest at least tieing into the in-kernel crypto api first, and then
> worrying about the userspace side of things, right?

Absolutely.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/