linux-kernel - Re: [PATCH 1/2] mm: Fix slab->page flags corruption.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+r2OQ5YmpCjDS09uQ5B2jMEWCF3V7NbZ0Q6jGwVhoZS9Q@mail.gmail.com>
Date:	Wed, 16 May 2012 11:40:21 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	andrea@...ranet.com, aarcange@...hat.com
Cc:	penberg@...nel.org, mpm@...enic.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, jesse@...ira.com, abhide@...ira.com,
	Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH 1/2] mm: Fix slab->page flags corruption.

On Mon, May 14, 2012 at 11:53 AM, Christoph Lameter <cl@...ux.com> wrote:
> On Mon, 14 May 2012, Pravin B Shelar wrote:
>
>> Transparent huge pages can change page->flags (PG_compound_lock)
>> without taking Slab lock. Since THP can not break slab pages we can
>> safely access compound page without taking compound lock.
>>
>> Specificly this patch fixes race between compound_unlock and slab
>> functions which does page-flags update. This can occur when
>> get_page/put_page is called on page from slab object.
>
> You need to also get this revbiewed by the THP folks like Andrea &
> friends.

Hi Andrea,

Can you comment on this patch.

Thanks.

>
> Reviewed-by: Christoph Lameter <cl@...ux.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/