linux-kernel - Re: [PATCH RFT 3/3] regulator: isl6271a: Convert to set_voltage_sel and regulator_map_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201205160429.31382.marek.vasut@gmail.com>
Date:	Wed, 16 May 2012 04:29:31 +0200
From:	Marek Vasut <marek.vasut@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH RFT 3/3] regulator: isl6271a: Convert to set_voltage_sel and regulator_map_voltage_linear

Dear Axel Lin,

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/regulator/isl6271a-regulator.c |   21 ++++++---------------
>  1 files changed, 6 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/regulator/isl6271a-regulator.c
> b/drivers/regulator/isl6271a-regulator.c index 00cb288..56d273f 100644
> --- a/drivers/regulator/isl6271a-regulator.c
> +++ b/drivers/regulator/isl6271a-regulator.c
> @@ -50,25 +50,15 @@ static int isl6271a_get_voltage_sel(struct
> regulator_dev *dev) return idx;
>  }
> 
> -static int isl6271a_set_voltage(struct regulator_dev *dev,
> -				int minuV, int maxuV,
> -				unsigned *selector)
> +static int isl6271a_set_voltage_sel(struct regulator_dev *dev,
> +				    unsigned selector)
>  {
>  	struct isl_pmic *pmic = rdev_get_drvdata(dev);
> -	int err, data;
> -
> -	if (minuV < ISL6271A_VOLTAGE_MIN || minuV > ISL6271A_VOLTAGE_MAX)
> -		return -EINVAL;
> -	if (maxuV < ISL6271A_VOLTAGE_MIN || maxuV > ISL6271A_VOLTAGE_MAX)
> -		return -EINVAL;
> -
> -	data = DIV_ROUND_UP(minuV - ISL6271A_VOLTAGE_MIN,
> -			    ISL6271A_VOLTAGE_STEP);
> -	*selector = data;
> +	int err;
> 
>  	mutex_lock(&pmic->mtx);
> 
> -	err = i2c_smbus_write_byte(pmic->client, data);
> +	err = i2c_smbus_write_byte(pmic->client, selector);
>  	if (err < 0)
>  		dev_err(&pmic->client->dev, "Error setting voltage\n");
> 
> @@ -78,8 +68,9 @@ static int isl6271a_set_voltage(struct regulator_dev
> *dev,
> 
>  static struct regulator_ops isl_core_ops = {
>  	.get_voltage_sel = isl6271a_get_voltage_sel,
> -	.set_voltage	= isl6271a_set_voltage,
> +	.set_voltage_sel = isl6271a_set_voltage_sel,
>  	.list_voltage	= regulator_list_voltage_linear,
> +	.map_voltage	= regulator_map_voltage_linear,
>  };
> 
>  static int isl6271a_get_fixed_voltage(struct regulator_dev *dev)

Hm well, I hope this won't break the driver. I can't test it any soon.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/