linux-kernel - Re: [PATCH 4/6] pstore/ram: Add some more documentation and examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMbhsRS-ZnkRw1Qaf4=ocd4EFTj2+wEkcFwGn7VbKfv7MV63dQ@mail.gmail.com>
Date:	Wed, 16 May 2012 15:25:17 -0700
From:	Colin Cross <ccross@...roid.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kees Cook <keescook@...omium.org>,
	Tony Luck <tony.luck@...el.com>, Arnd Bergmann <arnd@...db.de>,
	John Stultz <john.stultz@...aro.org>,
	Shuah Khan <shuahkhan@...il.com>, arve@...roid.com,
	Rebecca Schultz Zavin <rebecca@...roid.com>,
	Jesper Juhl <jj@...osbits.net>,
	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Thomas Meyer <thomas@...3r.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Marco Stornelli <marco.stornelli@...il.com>,
	WANG Cong <xiyou.wangcong@...il.com>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	linaro-kernel@...ts.linaro.org, patches@...aro.org,
	kernel-team@...roid.com
Subject: Re: [PATCH 4/6] pstore/ram: Add some more documentation and examples

On Wed, May 16, 2012 at 3:11 PM, Anton Vorontsov <cbouatmailru@...il.com> wrote:
> On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote:
> [...]
>> > +You can specify either RAM memory or peripheral devices' memory. However, when
>> > +specifying RAM, be sure to reserve the memory by issuing memblock_reserve()
>> > +very early in the architecture code, just before platform device registration,
>>
>> Just before platform device registration is way too late.  ARM
>> provides a machine reserve callback to allow board files to call
>> memblock_reserve inside arm_memblock_init() and before mm_init().
>
> Yeah, and I guess that 'too late' is also true for all architectures,
> the platform_device_register and friends are most probably unusable
> before mm_init, and after that it's always too late.
>
> So the word 'just' is misleading indeed, I'll remove it.

I think any reference to the time when platform devices are registered
is misleading.  There is a very specific point during arch init where
memblock_reserve is valid, and it is nowhere near platform device
registration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/