linux-kernel - Re: [PATCH][RESEND] gpio: Emma Mobile GPIO driver V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120517072450.GC11623@linux-sh.org>
Date:	Thu, 17 May 2012 16:24:50 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	linux-kernel@...r.kernel.org, rjw@...k.pl,
	linus.walleij@...ricsson.com, arnd@...db.de,
	linux-sh@...r.kernel.org, horms@...ge.net.au,
	grant.likely@...retlab.ca, olof@...om.net
Subject: Re: [PATCH][RESEND] gpio: Emma Mobile GPIO driver V2

On Thu, May 17, 2012 at 03:22:23PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@...nsource.se>
> 
> This patch is V2 of the Emma Mobile GPIO driver. This
> driver is designed to be reusable between multiple SoCs
> that share the same basic building block, but so far it
> has only been used on Emma Mobile EV2.
> 
> Each driver instance handles 32 GPIOs with individually
> maskable IRQs. The driver operates on two I/O memory 
> ranges and the 32 GPIOs are hooked up to two interrupts.
> 
> In the case of Emma Mobile EV2 this GPIO building block
> is used as main external interrupt controller hooking up
> 159 GPIOS as 159 interrupts via 5 driver instances and
> 10 interrupts to the GIC and the Cortex-A9 Dual.
> 
> Signed-off-by: Magnus Damm <damm@...nsource.se>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> 
>  Rafael, can you please pick up?
> 
>  Changes since V1:
>  - use inline for private data functions using container_of() 
>  - use BIT(n) instead of 1 << n
>  - added legacy irq domain support for static mappings

My distaste for arbitrary static mappings aside, it makes no sense to
support this as a module if the irq domain can't be cleaned up at
present.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/