linux-kernel - Re: [PATCH 3/8] i2c: i2c-bfin-twi: Break dead waiting loop if i2c device misbehaves.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM=Q2cujxAGes0c4Ls6L_fUENvJE=Vf10YXOvng3zku84eC6ng@mail.gmail.com>
Date:	Thu, 17 May 2012 16:21:24 +0530
From:	Shubhrajyoti Datta <omaplinuxkernel@...il.com>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	sonic.zhang@...log.com, Ben Dooks <ben-linux@...ff.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	linux-i2c@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 3/8] i2c: i2c-bfin-twi: Break dead waiting loop if i2c
 device misbehaves.

On Thu, May 17, 2012 at 10:53 AM, Mike Frysinger <vapier.adi@...il.com> wrote:
> On Thu, May 17, 2012 at 1:20 AM, Shubhrajyoti Datta
> <omaplinuxkernel@...il.com> wrote:
>> On Wed, May 16, 2012 at 12:50 PM,  <sonic.zhang@...log.com> wrote:
>>> From: Sonic Zhang <sonic.zhang@...log.com>
>>>
>>> Some fault i2c device may hold the sda/scl line and cause i2c driver
>>> wait in the BUS busy loop. This patch breaks this potential dead
>>> loop.
>>
>> How about using a non-busy loop while you are at it.
>
> the timings here are fairly small ...
OK no issues.
Anyways was just a suggestion.:-)

> -mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/