linux-kernel - Re: [PATCH 7/8] MIPS: smp: Warn on too early irq enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 May 2012 14:55:12 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Yong Zhang <yong.zhang0@...il.com>
CC:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	ralf@...ux-mips.org, david.daney@...ium.com
Subject: Re: [PATCH 7/8] MIPS: smp: Warn on too early irq enable

Hello.

On 17-05-2012 14:10, Yong Zhang wrote:

> From: Yong Zhang<yong.zhang@...driver.com>

> Just to catch a potential issue.

    Grammar nitpicking ahead. :-)

> Signed-off-by: Yong Zhang<yong.zhang0@...il.com>
> ---
>   arch/mips/kernel/smp.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)

> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 042145f..0d48598 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)
>
>   	synchronise_count_slave();
>
> +	/*
> +	 * irq will be enabled in ->smp_finish(), enable it too early

    s/enable/enabling/

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/