linux-kernel - [PATCH 1/1] checkpatch: don't fake typedefs with #define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 May 2012 15:52:12 +0300
From:	Phil Carmody <ext-phil.2.carmody@...ia.com>
To:	apw@...onical.com
Cc:	linux-kernel@...r.kernel.org, ext-phil.2.carmody@...ia.com
Subject: [PATCH 1/1] checkpatch: don't fake typedefs with #define

People seemed to be taking the "no typedefs" rule too literally,
and were using #define to abide by the letter rather than the
spirit of the law. E.g. #define FOO_t struct _FOO_t

Signed-off-by: Phil Carmody <ext-phil.2.carmody@...ia.com>
---
 scripts/checkpatch.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index faea0ec..7dc41c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2299,6 +2299,12 @@ sub process {
 			     "do not add new typedefs\n" . $herecurr);
 		}
 
+# check for deliberate avoidance of the above anti-typedef rule
+		if ($line =~ /#\s*define\s+$Ident\s+$Type\b/) {
+			WARN("NEW_TYPEDEFS",
+			     "do not fake typedefs using #define\n" . $herecurr);
+		}
+
 # * goes on variable not on type
 		# (char*[ const])
 		while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/