linux-kernel - Re: [RFC] printk: add relative printk timing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPXgP10EyOz9-GHhj2ubtudtpaGCHbshDyJywjqJGGMu_xkQDA@mail.gmail.com>
Date:	Thu, 17 May 2012 17:37:05 +0200
From:	Kay Sievers <kay@...y.org>
To:	Sasha Levin <levinsasha928@...il.com>
Cc:	greg@...ah.com, torvalds@...ux-foundation.org, mingo@...nel.org,
	linux-kernel@...r.kernel.org, joe@...ches.com, hpa@...nel.org,
	yinghai@...nel.org
Subject: Re: [RFC] printk: add relative printk timing support

On Thu, May 17, 2012 at 5:02 PM, Sasha Levin <levinsasha928@...il.com> wrote:
> This patch adds support for relative timestamps in printk output.

>  static size_t print_prefix(const struct log *msg, bool syslog, char *buf)

> +       } else if (printk_time == 2 || printk_time == 3) {
> +               static unsigned long long last_print;

We can have multiple concurrent users of the relative time calculation, right?

I guess the last_print needs to be localized to every possible user
and concurrent instance: syslog(dmesg),  syslog(/proc/kmsg), console
output, to not race against each other?

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/