linux-kernel - Re: [PATCH] staging: comedi: Convert struct addi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120517021805.GA32592@kroah.com>
Date:	Wed, 16 May 2012 19:18:05 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, fmhess@...rs.sourceforge.net,
	abbotti@....co.uk
Subject: Re: [PATCH] staging: comedi: Convert struct addi_board
 initialization to C99 format

On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
> Convert the struct addi_board initialization to C99 format and remove
> all the NULL or 0 initializers. This makes maintaining and editing the
> code simpler and less error prone.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: Mori Hess <fmhess@...rs.sourceforge.net>
> 
> ---
> 
> This patch is a bit large but should be easy enough to review.
> It does incease the size of the source file in bytes but it reduces
> the lines of code by 1103 lines.
> 
> There are 6 checkpatch warnings about lines over 80 characters
> due to the long CamelCase names for some of the functions.
> "Fixing" these actually hurts the readability of the code. The
> checkpatch warnings will be addressed later by renaming the
> CamelCase functions.

Nice job, this driver is a pain to read...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/