lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 May 2012 18:44:12 +0200 From: Sascha Hauer <s.hauer@...gutronix.de> To: Rob Lee <rob.lee@...aro.org> Cc: kernel@...gutronix.de, shawn.guo@...aro.org, u.kleine-koenig@...gutronix.de, richard.zhao@...escale.com, amit.kucheria@...aro.org, daniel.lezcano@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linaro-dev@...ts.linaro.org, patches@...aro.org, jj@...osbits.net Subject: Re: [PATCH v4 4/7] ARM: imx: Enable imx53 low power idle On Thu, May 17, 2012 at 09:46:21AM -0500, Rob Lee wrote: > On Wed, May 16, 2012 at 12:47 PM, Sascha Hauer <s.hauer@...gutronix.de> wrote: > >> > >> +void __init imx5_init_late(void) > >> +{ > >> + imx5_pm_init(); > >> +} > >> + > >> void __init imx51_init_late(void) > >> { > >> mx51_neon_fixup(); > >> - imx5_pm_init(); > >> + imx5_init_late(); > >> } > > > > Where would you add i.MX53 specific code above? Hint: imx5_init_late is > > the wrong function name. > > I added imx5_init_late for late_init functionality that is common > among all imx5. For example, in the future imx50 may use it as well. > But I can remove this and repeat the imx5_pm_init() calls for each > platform if you prefer that. The point is that the init_late callback should have a imx53_* name, otherwise if you call it imx5_* there is no place to add imx53 only functionality. You can always call imx5 specific things from imx53 context, but not the other way round. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists