linux-kernel - Re: [PATCH] Increase file size limit on FreeBSD UFS flavours

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120517161052.d37cf8ae.akpm@linux-foundation.org>
Date:	Thu, 17 May 2012 16:10:52 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Vladimir 'φ-coder/phcoder' Serbinenko 
	<phcoder@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Evgeniy Dushistov <dushistov@...l.ru>
Subject: Re: [PATCH] Increase file size limit on FreeBSD UFS flavours

On Sun, 13 May 2012 15:50:40 +0200
Vladimir '__-coder/phcoder' Serbinenko  <phcoder@...il.com> wrote:

> Increase the file size limit on FreeBSD UFS flavours.
> 
> Signed-off-by: Vladimir Serbinenko <phcoder@...il.com>
> 
> diff --git a/fs/ufs/super.c b/fs/ufs/super.c
> index ac8e279..7e80a68 100644
> --- a/fs/ufs/super.c
> +++ b/fs/ufs/super.c
> @@ -768,6 +768,7 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent)
>  		uspi->s_fshift = 9;
>  		uspi->s_sbsize = super_block_size = 1536;
>  		uspi->s_sbbase = 0;
> +		sb->s_maxbytes = MAX_LFS_FILESIZE;
>  		flags |= UFS_DE_44BSD | UFS_UID_44BSD | UFS_ST_44BSD | UFS_CG_44BSD;
>  		break;
>  	case UFS_MOUNT_UFSTYPE_UFS2:
> @@ -778,6 +779,7 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent)
>  		uspi->s_fshift = 9;
>  		uspi->s_sbsize = super_block_size = 1536;
>  		uspi->s_sbbase =  0;
> +		sb->s_maxbytes = MAX_LFS_FILESIZE;
>  		flags |= UFS_TYPE_UFS2 | UFS_DE_44BSD | UFS_UID_44BSD | UFS_ST_44BSD | UFS_CG_44BSD;
>  		break;
>  		

But MAX_NON_LFS exists for a reason.  Before this change, the Linux UFS
implementation had never had to deal with >4G files (I assume).

Are you telling us that the fs has been thoroughly audited and tested
with large files and that it all worked OK with no other changes?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/