linux-kernel - Re: [PATCH] V2: target: Handle ATA_PASS_THROUGH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337235191.32217.150.camel@haakon2.linux-iscsi.org>
Date:	Wed, 16 May 2012 23:13:11 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	mc@...ux.vnet.ibm.com
Cc:	James Bottomley <James.Bottomley@...senpartnership.com>,
	target-devel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com>
Subject: Re: [PATCH] V2: target: Handle ATA_PASS_THROUGH_16 passthrough

On Thu, 2012-05-17 at 11:14 +0800, mengcong wrote:
> The cdrecord uses ATA_PASS_THROUGH_16 command while burning CDs
> with a SATA CD-ROM. This patch adds support to it so that PSCSI 
> CD-ROM passthrough works with the cdrecord.
> 
> Signed-off-by: Cong Meng <mc@...ux.vnet.ibm.com>
> ---
>  drivers/target/target_core_transport.c |   30 ++++++++++++++++++++++++++++++
>  1 files changed, 30 insertions(+), 0 deletions(-)
> 

Ok, I've added the extra !passthrough check to enforce pSCSI backends
only usage + /* ... */ style comments changes mentioned as feedback you
missed in the last mail.  (That's OK this time, but please don't get
into the habit of ignoring patch feedback..)

So committed into lio-core.git, and queuing shortly into
target-pending/for-next to be picked up for tomorrow's linux-next build.

Thanks for your patch MC!

--nab

> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 2d75c29..25e0fc0 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -2926,6 +2926,36 @@ static int transport_generic_cmd_sequencer(
>  		size = (cdb[7] << 8) | cdb[8];
>  		cmd->se_cmd_flags |= SCF_SCSI_CONTROL_SG_IO_CDB;
>  		break;
> +	case ATA_16:
> +		// T_LENGTH
> +		switch (cdb[2] & 0x3) {
> +		case 0x0:
> +			sectors = 0;
> +			break;
> +		case 0x1:
> +			sectors = (((cdb[1] & 0x1) ? cdb[3] : 0) << 8) | cdb[4];
> +			break;
> +		case 0x2:
> +			sectors = (((cdb[1] & 0x1) ? cdb[5] : 0) << 8) | cdb[6];
> +			break;
> +		case 0x3:
> +			pr_err("T_LENGTH=0x3 not supported\n");
> +			goto out_invalid_cdb_field;
> +			break;
> +		}
> +		
> +		// BYTE_BLOCK
> +		if (cdb[2] & 0x4) {
> +			// BLOCK
> +			// T_TYPE: 512 or sector
> +			size = sectors * ((cdb[2] & 0x10) ? 
> +				dev->se_sub_dev->se_dev_attrib.block_size : 512);
> +		} else {
> +			// BYTE
> +			size = sectors;
> +		}
> +		cmd->se_cmd_flags |= SCF_SCSI_CONTROL_SG_IO_CDB;
> +		break;
>  	default:
>  		pr_warn("TARGET_CORE[%s]: Unsupported SCSI Opcode"
>  			" 0x%02x, sending CHECK_CONDITION.\n",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/