Message-ID: <4FB5F61C.7040203@illinois.edu>
Date:	Fri, 18 May 2012 02:11:24 -0500
From:	Matt Johnson <johnso87@...inois.edu>
To:	<jgarzik@...ox.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-ide@...r.kernel.org>
Subject: Re: [PATCH 1/1] ahci: Detect Marvell 88SE9172 SATA controller

Ping?  This patch has been rock-solid on this machine for the last 3 
weeks, and the machine won't boot without it.  I'm happy to provide any 
additional context, but otherwise, can this be committed?
Thanks!
-Matt

On 04/30/2012 02:22 PM, Matt Johnson wrote:
> For a bit more context, the Z68X-UD3H-B3 has the SATA controllers provided
> by the Z68 chipset plus an extra 2 SATA3 ports from a Marvell
> 88SE9172-NNX2.
> The 4 lines on the chip on my board read:
> 88SE9172-NNX2
> PAY4850.3
> 1116 A1P
> TW
>
> It seems that this chip is used on other boards as well
> (see http://www.techpowerup.com/reviews/Gigabyte/G1_Sniper2/5.html).
> I'm not sure whether 88SE9172-NNX2 is a distinct part from the 88SE9172, or
> whether the 'NNX2' is manufacturing metadata.
> In any case, drives connected to these 2 ports are not recognized at
> boot time
> in the latest kernel. I put /boot and the bootloader on a drive attached to
> one of the Marvell ports. Grub worked fine, but I couldn't boot the kernel;
> it just dumped me to busybox. Once in busybox, I could mount the drive with
> 'echo 1b4b 917a > /sys/bus/pci/drivers/ahci/new_id', and Ctrl+d would exit
> busybox and boot the kernel successfully.
>
> Others have run into similar issues (see
> http://theangryangel.co.uk/blog/marvell-88se9172-sata3-under-linux-as-of-320
> ,
> which has been copy-pasted onto the Marvell chipset Wikipedia page
> http://en.wikipedia.org/wiki/List_of_Marvell_Technology_Group_chipsets ).
> The PCI ID suggested in the linked page (1b4b 9192) didn't work for me,
> which suggests that either the poster's chip was not a 88se9172, there
> are multiple revs of 88se9172 with different PCI IDs, or the -NNX2 is a
> distinct model with its own PCI ID.
>
> In any case, I think accepting this patch will make boards like mine
> work in
> the near term, and we can add additional PCI IDs and clarify the comments
> for similar chips as people report them or as we get clarification from
> Marvell.
>
> With this patch, the vanilla and Ubuntu kernels both boot flawlessly with
> the boot partition hanging off the Marvell controller.
>
> Thanks,
> Matt
>
> On 04/27/2012 01:42 AM, Matt Johnson wrote:
>> The Marvell 88SE9172 SATA controller (PCI ID 1b4b 917a) already worked
>> once it was detected, but was missing an ahci_pci_tbl entry.
>>
>> Boot tested on a Gigabyte Z68X-UD3H-B3 motherboard.
>>
>> Signed-off-by: Matt Johnson <johnso87@...inois.edu>
>> ---
>> drivers/ata/ahci.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>> index 79a1e9d..ebaf67e 100644
>> --- a/drivers/ata/ahci.c
>> +++ b/drivers/ata/ahci.c
>> @@ -394,6 +394,8 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>> .driver_data = board_ahci_yes_fbs }, /* 88se9128 */
>> { PCI_DEVICE(0x1b4b, 0x9125),
>> .driver_data = board_ahci_yes_fbs }, /* 88se9125 */
>> + { PCI_DEVICE(0x1b4b, 0x917a),
>> + .driver_data = board_ahci_yes_fbs }, /* 88se9172 */
>> { PCI_DEVICE(0x1b4b, 0x91a3),
>> .driver_data = board_ahci_yes_fbs },
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists