linux-kernel - Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 May 2012 17:37:00 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	David Daney <ddaney.cavm@...il.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	"H.J. Lu" <hjl.tools@...il.com>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de
Subject: Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64_ds

It looks like MIPS has a private definition of struct msqid64_ds, as do
most other architectures; the MIPS one is completely broken for user
space usages as it uses CONFIG_* macros:

#if defined(CONFIG_32BIT) && !defined(CONFIG_CPU_LITTLE_ENDIAN)
        unsigned long   __unused2;
#endif
        __kernel_time_t msg_rtime;      /* last msgrcv time */
#if defined(CONFIG_32BIT) && defined(CONFIG_CPU_LITTLE_ENDIAN)
        unsigned long   __unused2;
#endif

It looks like the only users of asm-generic here are:

arch/microblaze/include/asm/msgbuf.h:#include <asm-generic/msgbuf.h>
arch/score/include/asm/msgbuf.h:#include <asm-generic/msgbuf.h>
arch/sh/include/asm/msgbuf.h:#include <asm-generic/msgbuf.h>
arch/x86/include/asm/msgbuf.h:#include <asm-generic/msgbuf.h>

... and unless I'm mistaken, x86 is the only one of those which isn't 32
bits only, which explains the reason it "works"...

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/