linux-kernel - Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FB59BAD.1020505@gmail.com>
Date:	Thu, 17 May 2012 17:45:33 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	Ralf Baechle <ralf@...ux-mips.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H.J. Lu" <hjl.tools@...il.com>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de
Subject: Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64_ds

On 05/17/2012 05:31 PM, H. Peter Anvin wrote:
> On 05/17/2012 05:29 PM, David Daney wrote:
>>
>> I don't know if that answers your question though.
>>
>
> Not in the slightest.  The question is how on Earth struct msqid64_ds
> isn't botched on MIPS.

It is botched.

#if defined(CONFIG_32BIT) && defined(CONFIG_CPU_LITTLE_ENDIAN) come out 
in the userspace header file.

On mips it would appear that asm/msgbuf.h is not unique in this manner:

# grep CONFIG *.h
fcntl.h:#ifdef CONFIG_32BIT
fcntl.h:#endif /* CONFIG_32BIT */
ioctls.h:#define TIOCSERCONFIG	0x5488
msgbuf.h:#if defined(CONFIG_32BIT) && !defined(CONFIG_CPU_LITTLE_ENDIAN)
msgbuf.h:#if defined(CONFIG_32BIT) && defined(CONFIG_CPU_LITTLE_ENDIAN)
msgbuf.h:#if defined(CONFIG_32BIT) && !defined(CONFIG_CPU_LITTLE_ENDIAN)
msgbuf.h:#if defined(CONFIG_32BIT) && defined(CONFIG_CPU_LITTLE_ENDIAN)
msgbuf.h:#if defined(CONFIG_32BIT) && !defined(CONFIG_CPU_LITTLE_ENDIAN)
msgbuf.h:#if defined(CONFIG_32BIT) && defined(CONFIG_CPU_LITTLE_ENDIAN)
ptrace.h:#ifdef CONFIG_32BIT
ptrace.h:#ifdef CONFIG_CPU_HAS_SMARTMIPS
ptrace.h:#ifdef CONFIG_MIPS_MT_SMTC
ptrace.h:#endif /* CONFIG_MIPS_MT_SMTC */
ptrace.h:#ifdef CONFIG_CPU_CAVIUM_OCTEON
resource.h:#ifdef CONFIG_32BIT
siginfo.h:#ifdef CONFIG_32BIT
siginfo.h:#ifdef CONFIG_64BIT
swab.h:#ifdef CONFIG_CPU_MIPSR2
swab.h: * Having already checked for CONFIG_CPU_MIPSR2, enable the
swab.h:#ifdef CONFIG_64BIT
swab.h:#endif /* CONFIG_64BIT */
swab.h:#endif /* CONFIG_CPU_MIPSR2 */

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/