| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4FB6230C.2080604@mev.co.uk> Date: Fri, 18 May 2012 11:23:08 +0100 From: Ian Abbott <abbotti@....co.uk> To: H Hartley Sweeten <hartleys@...ionengravers.com> CC: Linux Kernel <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, Ian Abbott <ian.abbott@....co.uk>, "fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> Subject: Re: [PATCH] staging: comedi: cleanup all the comedi_driver 'detach' functions On 2012-05-18 01:11, H Hartley Sweeten wrote: > 2. Remove all the printk noise in the detach functions > > All of the printk output is really just noise. The user did a rmmod to > unload the driver, we really don't need to tell them about it. I disagree. It's not that unusual for drivers to report device removal. (It's not necessarily due to an rmmod either, not that that really matters.) > Also, some of the messages are output using: > > dev_dbg(dev->hw_dev, ... > or > dev_info(dev->hw_dev, ... > > Unfortunately the hw_dev value is only used by drivers that are doing > DMA. For most drivers this variable is going to be NULL so the output > is not going to work as expected. Agreed, those are bugs introduced by someone else's "cleanup"! -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists