linux-kernel - RE: [PATCH v6 04/12] x86/smpboot.c: Don't offline CPU0 if any irq can not be migrated out of it and remove CPU0 check in smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C71220077185AE@ORSMSX105.amr.corp.intel.com>
Date:	Fri, 18 May 2012 01:47:09 +0000
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	Ingo Molnar <mingo@...nel.org>
CC:	"Luck, Tony" <tony.luck@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, H Peter Anvin <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Mallick, Asit K" <asit.k.mallick@...el.com>,
	Arjan Dan De Ven <arjan@...ux.intel.com>,
	"Brown, Len" <len.brown@...el.com>,
	"Srivatssa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	Chen Gong <gong.chen@...ux.intel.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-pm <linux-pm@...r.kernel.org>, x86 <x86@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: RE: [PATCH v6 04/12] x86/smpboot.c: Don't offline CPU0 if any irq
 can not be migrated out of it and remove CPU0 check in smp_callin()

> -----Original Message-----
> From: Siddha, Suresh B
> Sent: Thursday, May 17, 2012 3:47 PM
> To: Ingo Molnar
> Cc: Luck, Tony; Thomas Gleixner; Yu, Fenghua; Ingo Molnar; H Peter
> Anvin; Linus Torvalds; Andrew Morton; Mallick, Asit K; Arjan Dan De Ven;
> Brown, Len; Srivatssa S. Bhat; Randy Dunlap; Chen Gong; linux-kernel;
> linux-pm; x86; Peter Zijlstra
> Subject: Re: [PATCH v6 04/12] x86/smpboot.c: Don't offline CPU0 if any
> irq can not be migrated out of it and remove CPU0 check in smp_callin()
> 
> On Mon, 2012-05-14 at 14:17 +0200, Ingo Molnar wrote:
> > * Tony Luck <tony.luck@...el.com> wrote:
> >
> > > Biggest code impact of that is the extra code to bring cpu0
> > > back online using NMI instead of INIT. We can't use INIT
> > > because if cpu0 gets one, it just resets the whole machine :-(
> > > But obviously we'd like to avoid special cases where there is
> > > a sane way to do so.
> >
> > Could we just standardize on NMI bringup during regular bootup?
> 
> May be we can use the NMI or even better monitor/mwait based bringup to
> re-online an AP that is currently offline in play_dead(), specifically
> if we haven't lost that AP processor state because of suspend/resume
> event etc.
> 
> This can speed-up online if we want to use light weight online/offline
> of the AP's for saving power on mobile platforms.

Then booting up AP via INIT and putting AP online back via NMI/mwait will have different wakeup method and code. We probably need a way to tell if it is first AP bringup or online AP/BSP during run time.

And if offlined CPU is not in mwait (e.g. CPU without mwait feature), mwait based bringup won't work. Do we need to fall back to NMI wakeup if offlined CPU is not in mwait?

Thanks.

-Fenghua