linux-kernel - Re: [tip:sched/core] sched: Set TAINT_UNSAFE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337338974.573.27.camel@twins>
Date:	Fri, 18 May 2012 13:02:54 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	rdunlap@...otime.net, akpm@...ux-foundation.org,
	khlebnikov@...nvz.org, tglx@...utronix.de
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched: Set TAINT_UNSAFE_SMP after
 sleep-in-atomic bug

On Fri, 2012-05-18 at 03:48 -0700, tip-bot for Konstantin Khlebnikov
wrote:
> Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

This is the patch I objected to.. 

> +++ b/kernel/sched/core.c
> @@ -3138,6 +3138,7 @@ static noinline void __schedule_bug(struct task_struct *prev)
>  	if (irqs_disabled())
>  		print_irqtrace_events(prev);
>  	dump_stack();
> +	add_taint(TAINT_UNSAFE_SMP);
>  }

This should very much be TAINT_WARN.. it has nothing what so ever to do
with SMP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/