linux-kernel - [tip:core/debug] kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 May 2012 05:11:19 -0700
From:	tip-bot for Seiji Aguchi <seiji.aguchi@....com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, satoru.moriya@....com, hpa@...or.com,
	mingo@...nel.org, a.p.zijlstra@...llo.nl, seiji.aguchi@....com,
	tony.luck@...el.com, dle-develop@...ts.sourceforge.net,
	tglx@...utronix.de, dzickus@...hat.com
Subject: [tip:core/debug] kdump: Execute kmsg_dump(KMSG_DUMP_PANIC)
  after smp_send_stop()

Commit-ID:  62be73eafaa045d3233337303fb140f7f8a61135
Gitweb:     http://git.kernel.org/tip/62be73eafaa045d3233337303fb140f7f8a61135
Author:     Seiji Aguchi <seiji.aguchi@....com>
AuthorDate: Tue, 15 May 2012 17:35:09 -0400
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 18 May 2012 14:02:10 +0200

kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()

This patch moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop(),
to serialize the crash-logging process via smp_send_stop() and to
thus retrieve a more stable crash image of all CPUs stopped.

Signed-off-by: Seiji Aguchi <seiji.aguchi@....com>
Acked-by: Don Zickus <dzickus@...hat.com>
Cc: dle-develop@...ts.sourceforge.net <dle-develop@...ts.sourceforge.net>
Cc: Satoru Moriya <satoru.moriya@....com>
Cc: Tony Luck <tony.luck@...el.com>
Cc: a.p.zijlstra@...llo.nl <a.p.zijlstra@...llo.nl>
Link: http://lkml.kernel.org/r/5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/panic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index b6215b7..d2a5f4e 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -108,8 +108,6 @@ void panic(const char *fmt, ...)
 	 */
 	crash_kexec(NULL);
 
-	kmsg_dump(KMSG_DUMP_PANIC);
-
 	/*
 	 * Note smp_send_stop is the usual smp shutdown function, which
 	 * unfortunately means it may not be hardened to work in a panic
@@ -117,6 +115,8 @@ void panic(const char *fmt, ...)
 	 */
 	smp_send_stop();
 
+	kmsg_dump(KMSG_DUMP_PANIC);
+
 	atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
 
 	bust_spinlocks(0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/