linux-kernel - Re: [PATCH v2] UBIFS: read crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337347403.2483.48.camel@sauron.fi.intel.com>
Date:	Fri, 18 May 2012 16:23:23 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Joel Reardon <joel@...mbassador.com>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] UBIFS: read crypto_lookup from datanodes to znodes

On Wed, 2012-05-16 at 14:52 +0200, Joel Reardon wrote:
> +	if (key_type(c, &(zbr->key)) == UBIFS_DATA_KEY) {
> +		struct ubifs_data_node *dn = node;
> +		long long crypto_lookup = le64_to_cpu(dn->crypto_lookup);
> +		if (zbr->crypto_lookup != 0)
> +			ubifs_assert(zbr->crypto_lookup == crypto_lookup);
> +		else
> +			zbr->crypto_lookup = crypto_lookup;
> +	}

Could you please just inject this code directly to
'ubifs_tnc_read_node()' ? I think it is much easier and more nicer, no?

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)