linux-kernel - Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120518145617.710bc1d6@nehalam.linuxnetplumber.net>
Date:	Fri, 18 May 2012 14:56:17 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating
 space.

On Sat, 19 May 2012 03:15:37 +0530
Jeffrin Jose <ahiliation@...oo.co.in> wrote:

> Fixed a coding style issue relating to  space found
> by checkpatch.pl tool in net/ethernet/eth.c
> 
> Signed-off-by: Jeffrin Jose <ahiliation@...oo.co.in>
> ---
>  net/ethernet/eth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 36e5880..c847aa6 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
>  	 *      seems to set IFF_PROMISC.
>  	 */
>  
> -	else if (1 /*dev->flags&IFF_PROMISC */ ) {
> +	else if (1 /*dev->flags&IFF_PROMISC */) {
>  		if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
>  						      dev->dev_addr)))
>  			skb->pkt_type = PACKET_OTHERHOST;

Rather than put lips on a pig, why not remove the bogus if?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/