linux-kernel - Re: [PATCH v3] UBIFS: read crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337425233.2041.17.camel@koala>
Date:	Sat, 19 May 2012 14:00:33 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Joel Reardon <joel@...mbassador.com>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] UBIFS: read crypto_lookup from datanodes to znodes

On Sat, 2012-05-19 at 10:30 +0200, Joel Reardon wrote:
> +			crypto_lookup = le64_to_cpu(dn->crypto_lookup);
> +			if (zbr->crypto_lookup != 0)
> +				ubifs_assert(zbr->crypto_lookup ==
> +					     crypto_lookup);

This "crypto_lookup" name is too long. Would you mind if we re-name it
to "ksa_pos" instead (KSA position)? Then we'll wrap less lines.

We can do this as a separate patch on top of this one. How does this
sound to you?


-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)