lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 19 May 2012 17:48:18 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
CC:	mdharm-usb@...-eyed-alien.net, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1]USB:storage:fixed space at the start of a line issues.

Hello.

On 18-05-2012 23:18, Jeffrin Jose wrote:

> Fixed space at the start of a line issues found
> by checkpatch.pl tool in drivers/usb/storage/usual-tables.c

> Signed-off-by: Jeffrin Jose<ahiliation@...oo.co.in>
> ---
>   drivers/usb/storage/usual-tables.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

> diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> index b969279..f2301ee 100644
> --- a/drivers/usb/storage/usual-tables.c
> +++ b/drivers/usb/storage/usual-tables.c
> @@ -34,17 +34,17 @@
>   		    vendorName, productName, useProtocol, useTransport, \
>   		    initFunction, flags) \
>   { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> -  .driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
> +.driver_info = (flags)|(USB_US_TYPE_STOR<<24) }

    Spaces are usually replaced by tab. Without indentation this looks worse 
than it was.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ