linux-kernel - Re: [ 31/54] kmemleak: Fix the kmemleak tracking of the percpu areas with !SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120519144652.GA2067@kroah.com>
Date:	Sat, 19 May 2012 07:46:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Christoph Biedl <linux-kernel.bfrz@...chmal.in-ulm.de>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Sami Liedes <sami.liedes@....fi>,
	Tejun Heo <tj@...nel.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Catalin Marinas <catalin.marinas@....com>
Subject: Re: [ 31/54] kmemleak: Fix the kmemleak tracking of the percpu areas
 with !SMP

On Sat, May 19, 2012 at 03:27:33PM +0200, Christoph Biedl wrote:
> Greg KH wrote...
> 
> > 3.0-stable review patch.  If anyone has any objections, please let me know.
> 
> > From: Catalin Marinas <catalin.marinas@....com>
> > 
> > commit 100d13c3b5b9410f604b86f5e0a34da64b8cf659 upstream.
> 
> > +	/* kmemleak tracks the percpu allocations separately */
> > +	kmemleak_free(fc);
> 
> That one causes:
> 
>     mm/percpu.c: In function ‘setup_per_cpu_areas’:
>     mm/percpu.c:1877: error: implicit declaration of function ‘kmemleak_free’
>     make[1]: *** [mm/percpu.o] Error 1
>     make: *** [mm] Error 2

Odd, it doesn't cause that problem here for me, what ARCH are you
building for?  I'm on x86-64.

> Trivial fix, works for me: Add
> 
>     #include <linux/kmemleak.h>
> 
> to mm/percpu.c. FWIW, upstream did this in in f528f0b but I cannot
> tell whether that commit is in any way of interest for 3.0.x.

Actually, I don't think this is needed at all for 3.0 as percpu memleak
handling went in with the patch you reference above, so this would cause
problems on 3.0.  So I'll go delete that patch from the queue, thanks
for letting me know.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/