linux-kernel - Re: [PATCH -next] usb: add usb.h stubs for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FB7C0E4.4000008@xenotime.net>
Date:	Sat, 19 May 2012 08:48:52 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Ian Abbott <abbotti@....co.uk>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>,
	devel@...verdev.osuosl.org, USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH -next] usb: add usb.h stubs for CONFIG_USB not enabled

On 05/19/2012 07:30 AM, Alan Stern wrote:

> On Fri, 18 May 2012, Randy Dunlap wrote:
> 
>> From: Randy Dunlap <rdunlap@...otime.net>
>>
>> Add stubs for some usb core functions when CONFIG_USB
>> is not enabled.  This fixes these comedi build errors:
>>
>> ERROR: "usb_deregister" [drivers/staging/comedi/comedi.ko] undefined!
>> ERROR: "usb_register_driver" [drivers/staging/comedi/comedi.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
>> ---
>> I am only adding the stubs that are needed for comedi to build.
>> I expect that more stubs will be needed as more build errors are
>> found.  It seems to me that linux/usb.h might need more (major)
>> moving of lines to support more stubs in the future.
> 
> This doesn't seem like the right thing to do.  If a driver needs to 
> register with the USB core then that driver should depend on 
> CONFIG_USB.
> 
> On the other hand, if the driver is capable of being built without USB 
> support then it should use the necessary preprocessor tests to protect 
> calls to any USB routines.


Yeah, my first patch (not on linux-usb list) to staging/comedi/drivers.c
just surrounded the usb helper functions with IS_ENABLED(CONFIG_USB).
I'm fine with that patch, but Greg said that he wanted stubs...


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/