[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FB6EE9D.8010103@xenotime.net>
Date: Fri, 18 May 2012 17:51:41 -0700
From: Randy Dunlap <rdunlap@...otime.net>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Stephen Rothwell <sfr@...b.auug.org.au>,
linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
Ian Abbott <abbotti@....co.uk>,
Frank Mori Hess <fmhess@...rs.sourceforge.net>,
devel@...verdev.osuosl.org
Subject: Re: [PATCH -next] comedi: fix build when USB is not enabled
On 05/18/2012 05:50 PM, Greg Kroah-Hartman wrote:
> On Fri, May 18, 2012 at 05:46:13PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...otime.net>
>>
>> Calls to optional subsystems cannot be made indiscriminately.
>> Enclose all of the usb helper functions inside
>> #if IS_ENABLED(CONFIG_USB)
>> to fix these build errors.
>>
>> (The pci helper functions are OK since there are stubs in
>> linux/pci.h for the called functions when PCI is not enabled.
>> Possibly the same could be done for the called USB functions.)
>>
>> ERROR: "usb_deregister" [drivers/staging/comedi/comedi.ko] undefined!
>> ERROR: "usb_register_driver" [drivers/staging/comedi/comedi.ko] undefined!
>
> I would rather stub these out in usb.h instead, care to make a patch for
> that?
I'll see how that goes...
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists