linux-kernel - Re: [PATCH v2 2/2] x86: Added read_mostly declaration/definition to vars from smp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FB8F7E9.4020005@scalemp.com>
Date:	Sun, 20 May 2012 16:55:53 +0300
From:	Vlad <vlad@...lemp.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Shai Fultheim (Shai@...leMP.com)" <Shai@...lemp.com>
Subject: Re: [PATCH v2 2/2] x86: Added read_mostly declaration/definition
 to vars from smp.h

On 05/18/2012 11:14 AM, Ingo Molnar wrote:
> * Vlad Zolotarov<vlad@...lemp.com>  wrote:
>
>> Added a "read-mostly" qualifier to the following variables in smp.h:
>>   - cpu_sibling_map
>>   - cpu_core_map
>>   - cpu_llc_shared_map
>>   - cpu_llc_id
>>   - cpu_number
>>   - x86_cpu_to_apicid
>>   - x86_bios_cpu_apicid
>>   - x86_cpu_to_logical_apicid
>>
>> As long as all the variables above are only written during the initialization,
>> this change is meant to prevent the false sharing and improve the
>> performance on large multiprocessor systems.
>>
>> Signed-off-by: Vlad Zolotarov<vlad@...lemp.com>
>> Signed-off-by: Shai Fultheim<shai@...lemp.com>
>> ---
>>   arch/x86/include/asm/apic.h    |    2 +-
>>   arch/x86/include/asm/smp.h     |   16 ++++++++--------
>>   arch/x86/kernel/apic/apic.c    |    6 +++---
>>   arch/x86/kernel/setup_percpu.c |    2 +-
>>   arch/x86/kernel/smpboot.c      |    8 ++++----
>>   5 files changed, 17 insertions(+), 17 deletions(-)
>
> This does not build on !SMP kernels that has APIC enabled.

Oops... :) My bad. I'll rebase and respin.

Thanks,
vlad

>
> Thanks,
>
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/