linux-kernel - Re: [PATCH v2] gpio/generic: initialize basic_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120520021009.GA5810@S2100-06.ap.freescale.net>
Date:	Sun, 20 May 2012 10:10:11 +0800
From:	Shawn Guo <shawn.guo@...escale.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	Shawn Guo <shawn.guo@...aro.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	"Hans J. Koch" <hjk@...utronix.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Ryan Mallon <rmallon@...il.com>,
	Hartley Sweeten <hsweeten@...ionengravers.com>,
	<LW@...O-electronics.de>, Sascha Hauer <s.hauer@...gutronix.de>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] gpio/generic: initialize basic_mmio_gpio shadow
 variables properly

On Sat, May 19, 2012 at 12:12:42PM -0600, Grant Likely wrote:
> On Sat, 19 May 2012 16:55:51 +0800, Shawn Guo <shawn.guo@...aro.org> wrote:
> > It fixes the issue in gpio-generic that commit fb14921 (gpio/mxc: add
> > missing initialization of basic_mmio_gpio shadow variables) manged to
> > fix in gpio-mxc driver, so that other platform specific drivers do not
> > suffer from the same problem over and over again.
> > 
> > Changes since v1:
> > * Turn the last parameter "bool big_endian" into "unsigned long flags"
> >   and give those really quirky hardwares a chance to tell that reg_set
> >   and reg_dir are unreadable.
> > 
> > Signed-off-by: Shawn Guo <shawn.guo@...aro.org>
> 
> Applied, thanks.
> 
Grant,

Can you please pick up the RESEND version of the patch, which had
bgpio_pdev_probe adapt bgpio_init parameter change too?

-- 
Regards,
Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/