linux-kernel - Re: [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120521022921.GA13084@kroah.com>
Date:	Sun, 20 May 2012 19:29:21 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	broonie@...nsource.wolfsonmicro.com, thomas.abraham@...aro.org,
	grant.likely@...retlab.ca, sameo@...ux.intel.com,
	myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts

On Mon, May 21, 2012 at 08:28:34AM +0900, Chanwoo Choi wrote:
> Hi Greg,
> 
> On 05/19/2012 08:59 AM, Greg KH wrote:
> 
> > On Wed, May 16, 2012 at 04:41:44PM +0900, Chanwoo Choi wrote:
> >> From: Thomas Abraham <thomas.abraham@...aro.org>
> >>
> >> Add irq domain support for max8997 interrupts. The reverse mapping method
> >> used is linear mapping since the sub-drivers of max8997 such as regulator
> >> and charger drivers can use the max8997 irq_domain to get the linux irq
> >> number for max8997 interrupts. All uses of irq_base in platform data and
> >> max8997 driver private data are removed.
> >>
> >> Signed-off-by: Thomas Abraham <thomas.abraham@...aro.org>
> >> Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>
> >> Acked-by: Grant Likely <grant.likely@...retlab.ca>
> >> Acked-by: Samuel Ortiz <sameo@...ux.intel.com>
> >> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> >> 	[Fix two bug which set max8997->irq_domain and correct wrong parameter]
> >> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> > 
> > Same problem as before, I apply this and it breaks the build with the
> > following errors:
> > 
> > drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_irq_work’:
> > drivers/extcon/extcon-max8997.c:350:36: error: ‘struct max8997_dev’ has no member named ‘irq_base’
> > drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_probe’:
> > drivers/extcon/extcon-max8997.c:452:35: error: ‘struct max8997_platform_data’ has no member named ‘irq_base’
> > drivers/extcon/extcon-max8997.c: In function ‘max8997_muic_remove’:
> > drivers/extcon/extcon-max8997.c:514:19: error: ‘struct max8997_dev’ has no member named ‘irq_base’
> > 
> > Please fix.
> 
> I posted patchset including below two patch. The second patch fix that
> extcon-max8997 driver use irq_domain instead of irq_base field in
> 'struct max8997_dev'.
> 
> Please apply second patch when test this patchset.

No, you can not break the build at any point in the patch process,
sorry.

Please resend these so the build does not break, but note, you have
missed the merge window for 3.5, as 3.4 is now out (well, will be in a
few hours once kernel.org comes back from the dead...)

So you will have to wait for 3.5-rc1 to be released before I can apply
it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/