linux-kernel - Re: [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120521095540.GA1999@opensource.wolfsonmicro.com>
Date:	Mon, 21 May 2012 10:55:41 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	jonghwa3.lee@...sung.com
Cc:	linux-kernel@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Samuel Oritz <sameo@...ux.intel.com>,
	Liam Girdwood <trg@...com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Chiwoong Byun <woong.byun@...sung.com>
Subject: Re: [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver

On Mon, May 21, 2012 at 04:33:15PM +0900, jonghwa3.lee@...sung.com wrote:
> On 2012년 05월 21일 00:56, Mark Brown wrote:
> > On Fri, May 18, 2012 at 06:32:18PM +0900, Jonghwa Lee wrote:

> >> +	}, {
> >> +		.name	= "EN32KHz PMIC",
> >> +		.id	= MAX77686_P32KH,
> >> +		.ops	= &max77686_fixedvolt_ops,
> >> +		.type	= REGULATOR_VOLTAGE,
> >> +		.owner	= THIS_MODULE,
> >> +	},

> > These should be managed via the clock API now we have one.

> I already updated all your comments except only this one. Could you
> explain more details?

We now have a generic clock framework in drivers/clk so we should be
using that to provide drivers for clocks rather than putting them into
the regulator API which was always a bodge.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)