linux-kernel - [PATCH] [SCSI] scsi_pm: Argument to scsi_device_resume should be scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 21 May 2012 12:32:00 +0200
From:	Emil Goode <emilgoode@...il.com>
To:	JBottomley@...allels.com
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Emil Goode <emilgoode@...il.com>
Subject: [PATCH] [SCSI] scsi_pm: Argument to scsi_device_resume should be scsi_device pointer

The call to scsi_device_resume expects a struct scsi_device pointer.
We should use the to_scsi_device macro here.

Sparse is warning about this:
drivers/scsi/scsi_pm.c:30:5: warning:
	passing argument 1 of ‘scsi_device_resume’
	from incompatible pointer type [enabled by default]
	include/scsi/scsi_device.h:368:13: note:
	expected ‘struct scsi_device *’
	but argument is of type ‘struct device *’

Signed-off-by: Emil Goode <emilgoode@...il.com>
---
 drivers/scsi/scsi_pm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
index 9bd2c41..d4201de 100644
--- a/drivers/scsi/scsi_pm.c
+++ b/drivers/scsi/scsi_pm.c
@@ -27,7 +27,7 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg)
 		if (drv && drv->suspend) {
 			err = drv->suspend(dev, msg);
 			if (err)
-				scsi_device_resume(dev);
+				scsi_device_resume(to_scsi_device(dev));
 		}
 	}
 	dev_dbg(dev, "scsi suspend: %d\n", err);
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/