linux-kernel - Re: [PATCH] regulator: palmas: Use regulator_[list|map]_voltage_linear() for palmas_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBA316E.9050005@slimlogic.co.uk>
Date:	Mon, 21 May 2012 13:13:34 +0100
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: palmas: Use regulator_[list|map]_voltage_linear()
 for palmas_ops_smps10

This is a good improvement I missed.

Acked-by: Graeme Gregory <gg@...mlogic.co.uk>

On 21/05/12 12:46, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/regulator/palmas-regulator.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> index 9b7ca90..4fd8333 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -400,19 +400,14 @@ static struct regulator_ops palmas_ops_smps = {
>  	.map_voltage		= palmas_map_voltage_smps,
>  };
>  
> -static int palmas_list_voltage_smps10(struct regulator_dev *dev,
> -					unsigned selector)
> -{
> -	return 3750000 + (selector * 1250000);
> -}
> -
>  static struct regulator_ops palmas_ops_smps10 = {
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.enable			= regulator_enable_regmap,
>  	.disable		= regulator_disable_regmap,
>  	.get_voltage_sel	= regulator_get_voltage_sel_regmap,
>  	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
> -	.list_voltage		= palmas_list_voltage_smps10,
> +	.list_voltage		= regulator_list_voltage_linear;
> +	.map_voltage		= regulator_map_voltage_linear;
>  };
>  
>  static int palmas_is_enabled_ldo(struct regulator_dev *dev)
> @@ -675,6 +670,8 @@ static __devinit int palmas_probe(struct platform_device *pdev)
>  			pmic->desc[id].vsel_mask = SMPS10_VSEL;
>  			pmic->desc[id].enable_reg = PALMAS_SMPS10_STATUS;
>  			pmic->desc[id].enable_mask = SMPS10_BOOST_EN;
> +			pmic->desc[id].min_uV = 3750000;
> +			pmic->desc[id].uV_step = 1250000;
>  		}
>  
>  		pmic->desc[id].type = REGULATOR_VOLTAGE;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/