linux-kernel - Re: [PATCH NEXT]staging: "rts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBA5737.3010209@gmail.com>
Date:	Mon, 21 May 2012 07:54:47 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.

On 05/21/2012 07:35 AM, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
>> From: "Justin P. Mattock"<justinmattock@...il.com>
>>
>>   Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>    ^
> Your scripts are adding an extra space here.i

after git format-patch my signature is in the subject line. pressing 
enter a few times moves it down. is there a git command for properly 
aligning this?
>
>>
>> ---
>>
>> The below patch fixes some typos found while reading through rts_pstor.
>
> This could go in the patch description if you wanted.
>
>>
>>   drivers/staging/rts_pstor/ms.c |    2 +-
>>   drivers/staging/rts_pstor/sd.c |    2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
>> index 0bf6d95..3b75739 100644
>> --- a/drivers/staging/rts_pstor/ms.c
>> +++ b/drivers/staging/rts_pstor/ms.c
>> @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip)
>>
>>   	if (!CHK_MSPRO(ms_card)) {
>>   		/* Build table for the last segment,
>> -		 * to check if L2P talbe block exist,erasing it
>> +		 * to check if L2P table block exist,erasing it
>
> I still have no idea what this comment means but "exist" =>  "exists"
> and it needs a space after the comma.

most of them I have no idea as well.. anyway resending with the fixes..
>
>>   		*/
>>   		retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1);
>>   		if (retval != STATUS_SUCCESS) {
>
> regards,
> dan carpenter
>

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/