linux-kernel - [PATCH] drivers/leds/leds-lp5521.c: actually check return value of lp5521

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1337614542-31696-1-git-send-email-siretart@tauware.de>
Date:	Mon, 21 May 2012 17:35:42 +0200
From:	Reinhard Tartler <siretart@...ware.de>
To:	Bryan Wu <bryan.wu@...onical.com>,
	Richard Purdie <rpurdie@...ys.net>
Cc:	linux-kernel@...r.kernel.org,
	Reinhard Tartler <siretart@...ware.de>
Subject: [PATCH] drivers/leds/leds-lp5521.c: actually check return value of lp5521_read

This detects device failures properly. Fixes compiler warning:
drivers/leds/leds-lp5521.c:741: warning: 'buf' may be used uninitialized in this function

Signed-off-by: Reinhard Tartler <siretart@...ware.de>
---
 drivers/leds/leds-lp5521.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This problem was found by tools developed by the VAMOS project:
http://www4.cs.fau.de/Research/VAMOS/

diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 410a723..943c69d 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -785,7 +785,7 @@ static int __devinit lp5521_probe(struct i2c_client *client,
 	 * LP5521_REG_ENABLE register will not have any effect - strange!
 	 */
 	ret = lp5521_read(client, LP5521_REG_R_CURRENT, &buf);
-	if (buf != LP5521_REG_R_CURR_DEFAULT) {
+	if (ret == -EIO || buf != LP5521_REG_R_CURR_DEFAULT) {
 		dev_err(&client->dev, "error in resetting chip\n");
 		goto fail2;
 	}
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/