linux-kernel - Re: [tip:x86/urgent] x86, printk: Add missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337622999.13812.11.camel@joe2Laptop>
Date:	Mon, 21 May 2012 10:56:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	mingo@...nel.org, levinsasha928@...il.com,
	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86, printk: Add missing KERN_CONT to NMI
 selftest

On Mon, 2012-05-21 at 10:42 -0700, H. Peter Anvin wrote:
> On 05/21/2012 10:29 AM, Joe Perches wrote:
> > I believe this change is no longer required.
> > Kay's printk modifications have been updated.
> > It's somewhat useful, but the commit message
> > but not the commit subject is untrue.
> Still, the KERN_CONT should be there.

True.

All the other printks in the same file
without KERN_ levels should be fixed too.

It might be better to fix them all at once.

$ git grep -w -n printk arch/x86/kernel/nmi_selftest.c|grep -v KERN_|grep '[^"]\\n'
arch/x86/kernel/nmi_selftest.c:146:	printk("----------------\n");
arch/x86/kernel/nmi_selftest.c:147:	printk("| NMI testsuite:\n");
arch/x86/kernel/nmi_selftest.c:148:	printk("--------------------\n");
arch/x86/kernel/nmi_selftest.c:160:		printk("--------------------\n");
arch/x86/kernel/nmi_selftest.c:161:		printk("BUG: %3d unexpected failures (out of %3d) - debugging disabled! |\n",
arch/x86/kernel/nmi_selftest.c:163:		printk("-----------------------------------------------------------------\n");
arch/x86/kernel/nmi_selftest.c:165:		printk("--------------------\n");
arch/x86/kernel/nmi_selftest.c:166:		printk("%3d out of %3d testcases failed, as expected. |\n",
arch/x86/kernel/nmi_selftest.c:168:		printk("----------------------------------------------------\n");
arch/x86/kernel/nmi_selftest.c:170:		printk("--------------------\n");
arch/x86/kernel/nmi_selftest.c:171:		printk("All %3d testcases failed, as expected. |\n",
arch/x86/kernel/nmi_selftest.c:173:		printk("----------------------------------------\n");
arch/x86/kernel/nmi_selftest.c:175:		printk("--------------------\n");
arch/x86/kernel/nmi_selftest.c:176:		printk("Good, all %3d testcases passed! |\n",
arch/x86/kernel/nmi_selftest.c:178:		printk("---------------------------------\n");

There are a couple hundred more in arch/x86.

$ git grep -w printk arch/x86/|grep -v KERN_|wc -l
203


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/