linux-kernel - Re: [PATCH] xen: do not map the same GSI twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1205211901220.26786@kaball-desktop>
Date:	Mon, 21 May 2012 19:02:12 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen: do not map the same GSI twice

On Mon, 21 May 2012, Konrad Rzeszutek Wilk wrote:
> On Mon, May 21, 2012 at 06:47:44PM +0100, Stefano Stabellini wrote:
> > On Mon, 21 May 2012, Konrad Rzeszutek Wilk wrote:
> > > On Mon, May 21, 2012 at 04:54:10PM +0100, Stefano Stabellini wrote:
> > > > PV on HVM guests map GSIs into event channels; at restore time the
> > > > event channels are resumed by restore_pirqs.
> > > > Device drivers might try to register the same GSI again through ACPI at
> > > > restore time, but the GSI has already been mapped and bound by
> > > > restore_pirqs.
> > > 
> > > Which means... what kind of error do we get without this patch?
> > 
> > Xen would print:
> > 
> > (XEN) irq.c:2235: dom4: pirq 23 or emuirq 28 already mapped
> > 
> > and waste a pirq
> 
> OK. This sounds like it has been a bug since ..oh forever then?
> 

Yes. It only showed up since the ata_piix driver started registering the
GSI again on resume (I don't know when this behavior started exactly).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/