| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1337629176-1624-1-git-send-email-hdegoede@redhat.com> Date: Mon, 21 May 2012 21:39:36 +0200 From: Hans de Goede <hdegoede@...hat.com> To: Jiri Kosina <jkosina@...e.cz> Cc: linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com> Subject: [PATCH] usb-hid-core: Set intfdata to NULL if probe fails Having a dangling pointer in intfdata is no good, and may actually bite other drivers which rely on frameworks which only call dev_set_drvdata on the interface's device if no drvdata has been set (which is how I found out that usb-hid-core leaves the dangling pointer in there). Signed-off-by: Hans de Goede <hdegoede@...hat.com> --- drivers/hid/usbhid/hid-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c index 5bf91db..70d760f 100644 --- a/drivers/hid/usbhid/hid-core.c +++ b/drivers/hid/usbhid/hid-core.c @@ -1296,6 +1296,7 @@ err_free: kfree(usbhid); err: hid_destroy_device(hid); + usb_set_intfdata(intf, NULL); return ret; } -- 1.7.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists