linux-kernel - Re: [PATCH] Staging: android: alarm: Renamed pr_alarm to alarm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMXkaZEhDaj_qtPp8wu315HD1Nw_nK88cuZ1_jpaWqf8y1qvow@mail.gmail.com>
Date:	Mon, 21 May 2012 23:04:27 +0200
From:	Nasir Abed <nasirabed+kernel@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: alarm: Renamed pr_alarm to alarm_dbg

Hi Joe,

> Welcome to linux-kernel developing.
>
Thanks.

> It's generally pretty unnecessary to resubmit a variant of
> a patch that someone else has already submitted.
>
My mistake I should have double checked that first.

> If you want to get your 2nd patch in, that's great, but
> please consider doing work that isn't just checkpatch
> cleanups and isn't duplicative of work where you were cc'd.
>
That doesn't really sounds encouraging. Greg Kroah-Hartman
presentation on writing and submitting your (first) patch was my
inspiration to start helping out. However what you are saying might
scare away potential new developers.

> diff --git a/drivers/staging/android/alarm.c b/drivers/staging/android/alarm.c
>
> Is this done against -next or some other -staging tree?
>
I am using: http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Thanks for your feedback, very helpful.

Cheers,

Nasir Abed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/