[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1337580008-7280-8-git-send-email-yong.zhang0@gmail.com>
Date: Mon, 21 May 2012 14:00:07 +0800
From: Yong Zhang <yong.zhang0@...il.com>
To: linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Cc: ralf@...ux-mips.org, sshtylyov@...sta.com, david.daney@...ium.com
Subject: [PATCH 7/8] MIPS: smp: Warn on too early irq enable
From: Yong Zhang <yong.zhang@...driver.com>
Just to catch a potential issue.
Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
Acked-by: David Daney <david.daney@...ium.com>
---
arch/mips/kernel/smp.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 042145f..4fbafa8 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)
synchronise_count_slave();
+ /*
+ * irq will be enabled in ->smp_finish(), enabling it too early
+ * is dangerous.
+ */
+ WARN_ON_ONCE(!irqs_disabled());
mp_ops->smp_finish();
cpu_idle();
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists